feat: use uv lock file - #1427
Conversation
17f742f to
6932c1a
Compare
There was a problem hiding this comment.
Thanks for the changes @SMoraisAnsys, I left a couple of comments.
There is one other thing I have been thinking about, why can't we just use the uv lock files automatically once detected rather than exposing an explicit input for it (similar to how there is no input for poetry). IMO, a project that already uses a lock file would expect its dependencies to be installed from it.
I'm fine with detecting it and activating it by default. My only concern is the sudden change of behavior for people that still work with version tag and/or don't read every release note carefully. |
I could wait for this to get merged before v11 release, that way we have a graceful way of introducing this change. We can clearly document behavior change in the migration guide and those using tags won't be affected until they explicitly bump. What do you think? |
e6e7568 to
dd7aa72
Compare
bafab5e to
17e4df6
Compare
moe-ad
left a comment
There was a problem hiding this comment.
I think out of all the actions this has been extended to, _doc-build-windows, check-vulnerabilities and tests-pytest are the only ones not being tested directly in the actions pipelines. It will be nice if we can test those prior to merging, just to be certain things run fine.
Thanks for the major changes @SMoraisAnsys!
I was working on adding those tests in the other PR. |
|
Converted to draft until testing is fully performed (still some misses) |
51aa241 to
141acfa
Compare
This reverts commit 519bf7f.
Co-authored-by: Muhammed Adedigba <68085496+moe-ad@users.noreply.github.com>
Co-authored-by: Muhammed Adedigba <68085496+moe-ad@users.noreply.github.com>
Co-authored-by: Muhammed Adedigba <68085496+moe-ad@users.noreply.github.com>
Co-authored-by: Muhammed Adedigba <68085496+moe-ad@users.noreply.github.com>
Co-authored-by: Muhammed Adedigba <68085496+moe-ad@users.noreply.github.com>
Co-authored-by: Muhammed Adedigba <68085496+moe-ad@users.noreply.github.com>
Co-authored-by: Muhammed Adedigba <68085496+moe-ad@users.noreply.github.com>
Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
e207614 to
8bb98f6
Compare
Follow up of #1364 but with a clean branch.
Related to #1088, in particular this comment, and #1088.
The use of
uv add --group ansys-actions -r "${REQUIREMENTS_FILE}"has been removed in 10ddec7 because some hooks might check the pyproject.toml / uv.lock files and lead to CI failure. That is the case withpyansys-geometrywhich leveragespyproject-fmt.The smoke_test.py file has been updated in 6932c1a to be compatible with
uv's architecture to manage packages. I assume that we we weren't affected previously becauseuv pip installmimicspip's behavior. But when usinguv syncthat behavior changes and we can't useCWDto retrieve the dist files. Levering relative location solves this issue and seems to also work with other package managers.Note
To align the lockfile logic to the artificial project
ansys-actions-ci-dependencies, thedocdependency group has been added and the minimum version has been bumped. This aligns with our will to follow SPEC 0 and ensure that we keep using the same dependencies has the one that where defined inrequirements/requirements_doc.txtwhich has been removed ! Each action has it's requirements.txt file regenerated anddocutilshas been pinned back to0.22.4instead of0.23(automatic generation).Warning
On top of the breaking change associated to the use of dependencies, the project has been upgraded to python3.12+ compatibility. This means that from this point we might define (if not yet with this PR) dependencies that are not compatible for downstream workflows. I'm fine with it but we have to make it clear to users. Pinging @moe-ad for visibility.